Add workaround for broken pvesh output.
#205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b39460c to
5f4dfa9
Compare
5f4dfa9 to
c16375a
Compare
|
Please add tests for this new functionality. |
|
@jhollowe, added a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing as ansible-collections/community.general#4027 is still not merged after over 3 years because https://bugzilla.proxmox.com/show_bug.cgi?id=4333 still isn't fixed, I'd suggest adding this more generic workaround here rather than the very specific one in ansible-collections/community.general#4027.
Basically,
pveshcan contain random output before the JSON message, so try parsing one fewer line with each try, until we reach the end of the output.Seems like I actually suggested this 3 years ago: #117 (comment)