Use stdio directly on "dumb" terminals #2304
Conversation
|
I've tried to add an integration test of sorts, but the "No live threads left" error got the better of me. |
|
@andrehjr Check this out. |
45b2cf4 to
fbcec7c
Compare
|
Hi @dgutov I've made some additional changes on your PR. Can you try it? Investigating a bit more, it seems this issue only happens when Reline is used in Pry as input (Ruby 3.3+). When I've tried emacs on the shell with older versions of ruby there was no issue. I think this code might be removed if ruby/reline#660 changes how Reline treats TERM=dumb, but for now, it solves the echoing issue. |
|
@andrehjr This works for me, thank you. This particular issue indeed seems Reline-specific (there were other bugs before, also related to Reline, but in the context of Pry IIUC they were triggered only with Rubies compiled without libreadline, so those should be covered as well). Thanks for the link, I guess ruby/irb#907 also helped with that. Speaking of the difference in solution, I think switching to SimpleStdio whenever the terminal is |
|
@andrehjr Ping. |
|
Thanks for the ping.
I’ll take a look into this over the next few days 🙏
- André
…On Wed, 1 May 2024 at 12:50 Dmitry Gutov ***@***.***> wrote:
@andrehjr <https://github.com/andrehjr> Ping.
—
Reply to this email directly, view it on GitHub
<#2304 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAEEZN3N3PHMU4Z7OOKUQDZAEFNXAVCNFSM6AAAAABEWURGOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYGY3DKOBQGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Ping on this thx! |
Resolves #2303