8000 Fix wrong page when switching foldable state by ahmedre · Pull Request #3039 · quran/quran_android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Fix wrong page when switching foldable state #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Fix wrong page when switching foldable state #3039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions app/src/main/java/com/quran/labs/androidquran/ui/PagerActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,9 +349,15 @@ class PagerActivity : AppCompatActivity(), AudioBarListener, OnBookmarkTagsUpdat

private fun updateDualPageMode() {
val lastIsDualPages = isDualPages
isDualPages = QuranUtils.isDualPages(this, quranScreenInfo, isFoldableDeviceOpenAndVertical)
if (lastIsDualPages != isDualPages) {
val nextIsDualPages = QuranUtils.isDualPages(this, quranScreenInfo, isFoldableDeviceOpenAndVertical)
if (lastIsDualPages != nextIsDualPages) {
// due to the conversion after setting the adapter, we need this page to be
// the page _before_ we switched from dual to single or vice versa. otherwise,
// we end up double-converting the page.
//
// might be worth trying later to undo this and just remove the conversion below.
val page = currentPage
isDualPages = nextIsDualPages

pagerAdapter = QuranPageAdapter(
supportFragmentManager,
Expand Down
Loading
0