Add OpenPulseVisitor Skeleton and Initial OpenPulse AST Handling #229

vinayswamik · 2025-07-10T07:26:33Z

Summary of changes

This PR introduces the initial implementation of the OpenPulseVisitor. This visitor is designed to traverse and interact with elements in an OpenPulse program, providing a foundation for OpenPulse AST handling within the pyqasm framework.
This foundational work sets up the structure for OpenPulse support in pyqasm, enabling future development of OpenPulse parsing, validation, and transformation features. The current implementation provides scaffolding and type checks, with detailed TODOs for each OpenPulse construct.

Implement the detailed logic for each visitor method (frame/port/waveform management, function call evaluation, etc.).
Integrate with the rest of the pyqasm pipeline for end-to-end OpenPulse support.

Fixes #183

github-actions · 2025-07-10T07:26:42Z

👋 Hey there! It looks like the changelog might need an update.

Please take a moment to edit the CHANGELOG.md with:

A brief, one-to-two sentence summary of your changes.
A link back to this PR for reference.
(Optional) A small working example if you've added new features.

src/pyqasm/elements.py

src/pyqasm/openpulse_visitor.py

TheGupta2012 · 2025-07-10T12:37:16Z

src/pyqasm/visitor.py

+        calibration_stmts: list[openpulse_ast.Statement] = block_body.body
+        pulse_visitor = OpenPulseVisitor(module=self, is_def_cal=True)
+
+        result.extend(pulse_visitor.visit_basic_block(calibration_stmts))


I like this approach! Makes it very segregated from original visitor

src/pyqasm/visitor.py

src/pyqasm/openpulse_visitor.py

TheGupta2012

Thanks @vinayswamik , I like the segregated approach for pulse semantics!

Building on it, I've given some preliminary comments for refactoring. From the outset, let's keep the code organization in check - we don't want the OpenPulseVisitor to grow in size like our original visitor.

…ependencies

codecov-commenter · 2025-07-13T02:47:43Z

Codecov Report

Attention: Patch coverage is 16.21622% with 186 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/pyqasm/pulse/openpulse_visitor.py	11.64%	167 Missing ⚠️
src/pyqasm/visitor.py	29.62%	19 Missing ⚠️

📢 Thoughts on this report? Let us know!

vinayswamik added 4 commits July 10, 2025 02:14

Add calibration handling in QasmVisitor

c222948

Add Frame class to represent frames in OpenPulse

07085f1

Add OpenPulseVisitor module to handle OpenPulse program elements

21675e1

Update tox.ini

50774c5

vinayswamik requested a review from TheGupta2012 as a code owner July 10, 2025 07:26

vinayswamik force-pushed the feature/openpulse branch from 0e12fed to 50774c5 Compare July 10, 2025 07:45