8000 Don't set CMAKE_CXX_FLAGS, use target properties instead by danvratil · Pull Request #267 · qcoro/qcoro · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Don't set CMAKE_CXX_FLAGS, use target properties instead #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2025
Merged

Don't set CMAKE_CXX_FLAGS, use target properties instead #267

merged 2 commits into from
Mar 16, 2025

Conversation

danvratil
Copy link
Collaborator

This prevents our flags from affecting projects that use QCoro.

@danvratil danvratil force-pushed the use-target-properties branch from 63878eb to ca68391 Compare February 25, 2025 21:45
danvratil and others added 2 commits February 26, 2025 10:17
@danvratil
Don't set CMAKE_CXX_FLAGS, use target properties instead
b5c4cc9 
This prevents our flags from affecting projects that use QCoro.
@danvratil
Fixup
911280c
@danvratil danvratil force-pushed the use-target-properties branch from 654c925 to 911280c Compare February 26, 2025 09:17
@danvratil danvratil merged commit e7879aa into main Mar 16, 2025
42 checks passed
@danvratil danvratil deleted the use-target-properties branch March 16, 2025 10:12
@danvratil danvratil mentioned this pull request Mar 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
D 3804 evelopment

Successfully merging this pull request may close these issues.
1 participant
@danvratil
0