clean up NONEOS and MCU group #973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elicn
reviewed
Nov 2, 2021
|
|
||
|
|
||
| if self._code == None: | ||
| self._code = "qiling" |
There was a problem hiding this comment.
_code is usually tested for None to determine whether we are running a shellcode or not.
I am not sure why _code is set here to some magic string, but I guess it would result in some unexpected behavior.
| if self._argv is None: | ||
| self._argv = ["qilingcode"] | ||
| if self._rootfs is None: | ||
| self._rootfs = "." | ||
|
|
||
|
|
||
| self._interpreter = True if self._archtype in (QL_ARCH_INTERPRETER) else False |
There was a problem hiding this comment.
Just self._archtype in (QL_ARCH_INTERPRETER) will do.
It is already a boolean predicate.
| return self._interpreter | ||
|
|
||
| @interpreter.setter | ||
| def interpreter(self, i): |
There was a problem hiding this comment.
Shouldn't this property be read-only?
What is the rationale in letting it be writeable?
(same goes for baremetal)
| @@ -629,6 +630,31 @@ def uc(self) -> Uc: | |||
| def uc(self, u): | |||
| self._uc = u | |||
|
|
|||
| @property | |||
| def interpreter(self) -> bool: | |||
| """ Raw uc instance. | |||
There was a problem hiding this comment.
An unclear / wrong comment is worse than no comment (:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing