8000 Introduce “riscv” architecture to qiling by cla7aye15I4nd · Pull Request #980 · qilingframework/qiling · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Introduce “riscv” architecture to qiling #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Nov 10, 2021
Merged

Introduce “riscv” architecture to qiling #980

merged 32 commits into from
Nov 10, 2021

Conversation

cla7aye15I4nd
Copy link
Member
@cla7aye15I4nd cla7aye15I4nd commented Nov 4, 2021 •
edited
Loading

riscv architecture for the development of mcu.

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has 8000 been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing

@cla7aye15I4nd
Copy link
Member Author

May be we can add testcases and merge it until new version unicorn (without 'ecall' bug) released.

xwings
xwings reviewed Nov 10, 2021
View reviewed changes
qiling/utils.py


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why two line spacing ?

qiling/utils.py Outdated
@@ -380,7 +389,7 @@ def ql_guess_emu_env(path: str) -> Tuple[Optional[QL_ARCH], Optional[QL_OS], Opt
if os.path.isfile(path) and path.endswith('.DOS_EXE'):
return QL_ARCH.A8086, QL_OS.DOS, QL_ENDIAN.EL

arch, ostype, endian = ql_elf_parse_emu_env(path)
arch, ostype, endian = ql_elf_parse_emu_env(path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional tab ?

@xwings xwings merged commit f51dd88 into qilingframework:dev Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xwings xwings xwings left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cla7aye15I4nd @xwings
0