8000 fix(memory): remove misused region bound check of unmap_all by chinggg · Pull Request #1144 · qilingframework/qiling · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(memory): remove misused region bound check of unmap_all #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2022
Merged

fix(memory): remove misused region bound check of unmap_all #1144

merged 1 commit into from
May 1, 2022

Conversation

chinggg
Copy link
Contributor
@chinggg chinggg commented May 1, 2022

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing

If self.ql.uc.mem_regions() works properly, there is no need to check begin and and. Moreover, begin=0 is a false negative.

closes #1141

@wtdcode wtdcode merged commit c05972f into qilingframework:dev May 1, 2022
@wtdcode
Copy link
Member
wtdcode commented May 1, 2022

Thanks and welcome ; )

@chinggg chinggg deleted the fix-unmap_all branch May 1, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elicn elicn elicn approved these changes

@wtdcode wtdcode 50A2 wtdcode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chinggg @wtdcode @elicn
0