8000 Introduce PowerPC architecture to qiling by bet4it · Pull Request #1140 · qilingframework/qiling · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Introduce PowerPC architecture to qiling #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2022
Merged

Introduce PowerPC architecture to qiling #1140

merged 1 commit into from
Apr 28, 2022

Conversation

bet4it
Copy link
Contributor
@bet4it bet4it commented Apr 25, 2022

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing

The test binaries are provided in qilingframework/rootfs#29

@bet4it bet4it force-pushed the powerpc branch 2 times, most recently from f655c98 to cf451d9 Compare April 26, 2022 04:29
@xwings
Copy link
Member
xwings commented Apr 26, 2022

There is still some error in CI after adding the file.

@bet4it bet4it force-pushed the powerpc branch 2 times, most recently from ae9bd3d to 08fc7d9 Compare April 26, 2022 11:18
elicn
elicn approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member
@elicn elicn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution!
I am curious whether extending Qiling with a new architecture was an easy task, or not..?

qiling/arch/ppc_const.py
"f31": UC_PPC_REG_FPR31,
}

class MSR(IntEnum):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that Flag ot IntFlag would be a better fit here (see here).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could search IntEnum in the code. There are many usages of IntEnum, but none of Flag or IntFlag. So if we really want to change it, that could be another PR.

@xwings
Copy link
Member
xwings commented Apr 28, 2022

Amazing!

@xwings xwings merged commit 6fe3fa4 into qilingframework:dev Apr 28, 2022
@xwings
Copy link
Member
xwings commented Apr 28, 2022

Thanks !

@bet4it bet4it deleted the powerpc branch April 28, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xwings xwings xwings approved these changes

@elicn elicn elicn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bet4it @xwings @elicn
0