8000 Collect a few additional DLLs for x8664 by jasperla · Pull Request #1167 · qilingframework/qiling · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Collect a few additional DLLs for x8664 #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2022
Merged

Collect a few additional DLLs for x8664 #1167

merged 1 commit into from
Jun 4, 2022

Conversation

jasperla
Copy link
@jasperla jasperla commented Jun 2, 2022 •
edited
Loading

Remove a duplicate line for 32-bit while here.

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing

Collect a few additional DLLs for x8664
06a2a7e 
Remove a duplicate line for 32-bit while here.
@elicn
Copy link
Member
elicn commented Jun 2, 2022

Thanks for the PR.

This is a partial list by definition (otherwise we would have copied *.dll) so it is expected to miss some DLLs. Anyway, I'll approve it.

@xwings
Copy link
Member
xwings commented Jun 4, 2022

Approved. Welcome to Qiling!

@xwings xwings merged commit 08e2751 into qilingframework:dev Jun 4, 2022
@jasperla jasperla deleted the dlls branch June 5, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xwings xwings xwings approved these changes

@elicn elicn elicn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasperla @elicn @xwings
0