8000 Use global cwd in thread by bet4it · Pull Request #1170 · qilingframework/qiling · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use global cwd in thread #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2022
Merged

Use global cwd in thread #1170

merged 1 commit into from
Jun 18, 2022

Conversation

bet4it
Copy link
Contributor
@bet4it bet4it commented Jun 11, 2022

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing

All threads share the same cwd.

@kabeor
Copy link
Member
kabeor commented Jun 18, 2022

Thanks！And congratulations on becoming a key contributor of Qiling.

@kabeor kabeor merged commit 54a5169 into qilingframework:dev Jun 18, 2022
@bet4it bet4it deleted the cwd branch June 18, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elicn elicn elicn approved these changes

@kabeor kabeor kabeor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bet4it @kabeor @elicn
0