8000 Fix gdb step/continue handling by oscardagrach · Pull Request #1200 · qilingframework/qiling · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix gdb step/continue handling #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2022
Merged

Fix gdb step/continue handling #1200

merged 1 commit into from
Aug 4, 2022

Conversation

oscardagrach
Copy link

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing

Proposing a simple check for a separator in gdb command groups to determine whether
we need to split the command or not. If we don't, simply pass the 'c' or 's' command to the
proper handler. This fixes step/continue command handling in gdb. I'm not sure if this is too
hacky to be a long term solution but seemed simple enough and produced the desired result.

elicn
elicn requested changes Aug 3, 2022
View reviewed changes
Copy link
Member
@elicn elicn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi and thanks for the contribution.
Please see my review comments.

@rgrachek
Fix gdb step/continue handling
e310c48 
If there's no command to split, don't split it.
Instead, just copy the single command from grp
to cmd.
@oscardagrach oscardagrach requested a review from elicn August 3, 2022 15:11
@kabeor
Copy link
Member
kabeor commented Aug 4, 2022

Great, thanks for your contribution, merged.

@kabeor kabeor merged commit 33799ed into qilingframework:dev Aug 4, 2022
@oscardagrach oscardagrach deleted the gdb-fix branch August 4, 2022 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elicn elicn elicn approved these changes

@kabeor kabeor kabeor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oscardagrach @kabeor @elicn @rgrachek
0