Improvements around POSIX sockets #1216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved flexibility around POSIX sockets, after troubleshooting #1214.
Problem
POSIX socket ioctl receives an ifreq structure as an input, where the
ifr_namefield specifies the name of the network interface. Since Qiling uses native OS sockets under the hood, the interface name passed in theifr_namefield is expected to match the local network interface name.The Tenda AC15xx firmware specifies
br0as the interface name, and if the local network interface name is different (e.g.eth0), the underlying ioctl operation fails with anOSErrorsayingNo such device.Solution
This PR adds a new option to the NETWORK profile section:
ifrname_override. When enabled, Qiling will patch theifr_namefield before passing the data bytes to the udnerlying ioctl. The user may choose to avoid that override by commenting out the option in the profile.Other