8000 Implement ql_syscall_sched_yield by vhertz · Pull Request #1237 · qilingframework/qiling · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement ql_syscall_sched_yield #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2022
Merged

Implement ql_syscall_sched_yield #1237

merged 1 commit into from
Oct 6, 2022

Conversation

vhertz
Copy link
Contributor
@vhertz vhertz commented Oct 1, 2022 •
edited
Loading

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing

I implemented ql_syscall_sched_yield() for POSIX's sched_yield(2). It stops the emulation of a current thread and sets _sched_yield() to its sched_cb.

Should I write a new test for this?

wtdcode
wtdcode approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member
@wtdcode wtdcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xwings
Copy link
Member
xwings commented Oct 6, 2022

If you have a binary and src for this will be awesome.

I will merge for now and and test can be in later.

@xwings xwings merged commit ebf6222 into qilingframework:dev Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xwings xwings xwings approved these changes

@wtdcode wtdcode wtdcode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vhertz @xwings @wtdcode
0