feat: enhance about ip revise logic #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e7c783e to
4ff241e
Compare
< 10000 a href="https://codecov.io/gh/qiniu/goc/pull/290?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qiniu" rel="nofollow">Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
- Coverage 70.90% 70.76% -0.15%
==========================================
Files 34 34
Lines 2038 2035 -3
==========================================
- Hits 1445 1440 -5
- Misses 480 481 +1
- Partials 113 114 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lyyyuna
requested changes
Jul 21, 2022
| ) | ||
|
|
||
| func init() { | ||
| registerCmd.Flags().StringVarP(¢er, "center", "", "http://127.0.0.1:7777", "cover profile host center") | ||
| registerCmd.Flags().StringVarP(&name, "name", "n", "", "service name") | ||
| registerCmd.Flags().StringVarP(&address, "address", "a", "", "service address") | ||
| registerCmd.Flags().StringVarP(&ipRevise, "ip_revise", "", "true", "whether to do ip revise during registering") |
|
|
||
| func init() { | ||
| serverCmd.Flags().StringVarP(&port, "port", "", ":7777", "listen port to start a coverage host center") | ||
| serverCmd.Flags().StringVarP(&localPersistence, "local-persistence", "", "_svrs_address.txt", "the file to save services address information") | ||
| serverCmd.Flags().BoolVarP(&iprevise, "ip_revise", "", true, "setting the network type(default:regist server use proxy or under nat、same network ect,direct:use register request parm)") | ||
| serverCmd.Flags().BoolVarP(&IPRevise, "ip_revise", "", true, "whether to do ip revise during registering. Recommend to set this as false if under NAT or Proxy environment") |
There was a problem hiding this comment.
客户端和服务端的 ip_revise 参数类型未统一，命令行使用上会给用户造成困惑。
There was a problem hiding this comment.
服务端 ip_revise 设置默认值，客户端的 ip_revise 可以覆盖服务端默认值。
A053
lyyyuna
approved these changes
Jul 21, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CarlJi, lyyyuna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.