8000 Append `Goc` suffix in injected funtion name, to avoid declaration conflict in main pkg. by Blaxon · Pull Request #326 · qiniu/goc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Append Goc suffix in injected funtion name, to avoid declaration conflict in main pkg. #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2023
Merged

Append Goc suffix in injected funtion name, to avoid declaration conflict in main pkg. #326

merged 2 commits into from
Feb 24, 2023

Conversation

Blaxon
Copy link
Contributor
@Blaxon Blaxon commented Feb 21, 2023 •
edited
Loading

To solve issue raised in #325

@Blaxon
Copy link
Contributor Author
Blaxon commented Feb 21, 2023

/assign @memoryliu

@CarlJi
Copy link
Collaborator
CarlJi commented Feb 21, 2023

/unassign @memoryliu
/assign @CarlJi

@qiniu-bot qiniu-bot assigned CarlJi and unassigned memoryliu Feb 21, 2023
@Blaxon
Copy link
Contributor Author
Blaxon commented Feb 22, 2023

Hi @CarlJi I saw there is a failure in e2e test / E2E test (1.16.x) (pull_request) check, should I care about this? thanks

@qiniu-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Blaxon
To complete the pull request process, please assign carlji
You can assign the PR to them by writing /assign @carlji in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Blaxon Blaxon force-pushed the enhancement/issue-325/avoid-declaration-conflict-in-main-pkg branch from 9113d87 to 25814a4 Compare February 24, 2023 08:15
@codecov
Copy link
codecov bot commented Feb 24, 2023

Codecov Report

Merging #326 (7c21f3a) into master (5868a3e) will not change coverage.
The diff coverage is n/a.

❗ Current head 7c21f3a differs from pull request most recent head 77a9a1d. Consider uploading reports for the commit 77a9a1d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   70.76%   70.76%           
=======================================
  Files          34       34           
  Lines        2035     2035           
=======================================
  Hits         1440     1440           
  Misses        482      482           
  Partials      113      113
Flag Coverage Δ
e2e-1.16.x ?
e2e-1.17.x ?
e2e-1.18.x ?
e2e-1.19.x ?
unittest-1.16.x 70.76% <ø> (+0.09%) ⬆️
unittest-1.17.x 70.66% <ø> (ø)
unittest-1.18.x 70.66% <ø> (ø)
unittest-1.19.x 70.66% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cover/instrument.go 20.83% <ø> (ø)

@CarlJi CarlJi merged commit a3dfbf5 into qiniu:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CarlJi CarlJi

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Blaxon @CarlJi @qiniu-bot @memoryliu
0