8000 chore: fix the changes with combine of vuetify + vuetifyx by danni-cool · Pull Request #478 · qor5/admin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: fix the changes with combine of vuetify + vuetifyx #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 15, 2024
Merged

chore: fix the changes with combine of vuetify + vuetifyx #478

merged 2 commits into from
Aug 15, 2024

Conversation

danni-cool
Copy link
Contributor
@danni-cool danni-cool commented Aug 14, 2024 •
edited
Loading
  1. 固定了vuetify 的版本号，js和css都是3.16.4，避免每次拉最新cdn，api变动带来的潜在bug
  2. 现在main.js 只需要引用 vuetifyxjs.min.js (原 vuetify.js + vuetifyx.umd.js) 和 core.js
  3. 这次提交依赖项，不然go编译不通过 Feat UI reborn x#245

@danni-cool danni-cool requested review from sunfmin and molon August 14, 2024 15:34
@codecov Codecov
Copy link
codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files Patch % Lines
docs/docsrc/examples/examples_vuetify/mux.go 0.00% 1 Missing ⚠️
docs/docsrc/examples/examples_vuetifyx/mux.go 0.00% 1 Missing ⚠️
Files Coverage Δ
presets/presets.go 73.42% <100.00%> (-0.07%) ⬇️
docs/docsrc/examples/examples_vuetify/mux.go 0.00% <0.00%> (ø)
docs/docsrc/examples/examples_vuetifyx/mux.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@molon molon merged commit cc2a7ec into main Aug 15, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunfmin sunfmin sunfmin approved these changes

@molon molon Awaiting requested review from molon

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danni-cool @sunfmin @theplant-ci @molon
0