8000 section: list section add row no longer save direct by ZLValien · Pull Request #511 · qor5/admin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

section: list section add row no longer save direct #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 22, 2024
Merged

section: list section add row no longer save direct #511

merged 10 commits into from
Aug 22, 2024

Conversation

ZLValien
Copy link
Contributor
@ZLValien ZLValien commented Aug 22, 2024 •
edited
Loading
  1. List section add row no longer save data directly.
    Only when clicking the save button, the created section will be saved to the DB
  2. Support default element. You only need to use Edit() and View(), you can get a default element.
  3. Rename detailListField => sectionList

@codecov 8000 Codecov
Copy link
codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 63.81579% with 55 lines in your changes missing coverage. Please review.

Files Patch % Lines
presets/section.go 69.91% 30 Missing and 7 partials ⚠️
presets/detailing.go 37.93% 13 Missing and 5 partials ⚠️
Files Coverage Δ
presets/detailing.go 60.76% <37.93%> (+0.23%) ⬆️
presets/section.go 78.62% <69.91%> (+2.29%) ⬆️

... and 6 files with indirect coverage changes

@ZLValien ZLValien merged commit f0e1031 into main Aug 22, 2024
3 checks passed
@ZLValien ZLValien deleted the feat-list-section-default branch August 22, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molon molon molon approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZLValien @molon @theplant-ci
0