8000 pagebuilder with template by zhangshanwen · Pull Request #538 · qor5/admin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

pagebuilder with template #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2024
Merged

pagebuilder with template #538

merged 1 commit into from
Aug 30, 2024

Conversation

zhangshanwen
Copy link
Contributor

No description provided.

@zhangshanwen zhangshanwen requested a review from molon August 30, 2024 08:21
@codecov Codecov
Copy link
codecov bot commented Aug 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.29155% with 228 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pagebuilder/model_events.go 76.31% 105 Missing and 21 partials ⚠️
pagebuilder/template.go 84.84% 37 Missing and 13 partials ⚠️
pagebuilder/template_events.go 10.25% 35 Missing ⚠️
pagebuilder/page.go 91.96% 4 Missing and 5 partials ⚠️
pagebuilder/model.go 89.36% 2 Missing and 3 partials ⚠️
media/list.go 60.00% 1 Missing and 1 partial ⚠️
pagebuilder/builder.go 90.90% 1 Missing ⚠️
Files with missing lines Coverage Δ
media/filechooser.go 88.41% <100.00%> (ø)
pagebuilder/content.go 100.00% <100.00%> (+27.27%) ⬆️
pagebuilder/editor.go 55.39% <100.00%> (+0.92%) ⬆️
pagebuilder/messages.go 33.33% <ø> (ø)
pagebuilder/models.go 88.23% <100.00%> (+13.49%) ⬆️
pagebuilder/settings.go 76.11% <100.00%> (-13.62%) ⬇️
pagebuilder/builder.go 67.94% <90.90%> (+6.95%) ⬆️
media/list.go 92.30% <60.00%> (-7.70%) ⬇️
pagebuilder/model.go 69.29% <89.36%> (-1.82%) ⬇️
pagebuilder/page.go 91.96% <91.96%> (ø)
... and 3 more

... and 6 files with indirect coverage changes

@zhangshanwen zhangshanwen merged commit 542fbc3 into main Aug 30, 2024
3 checks passed
@zhangshanwen zhangshanwen deleted the feat-template branch August 30, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molon molon molon approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangshanwen @molon @theplant-ci
0