8000 deepsource: fix some simple by molon · Pull Request #555 · qor5/admin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

deepsource: fix some simple #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2024
Merged

deepsource: fix some simple #555

merged 2 commits into from
Sep 4, 2024

Conversation

molon
Copy link
Contributor
@molon molon commented Sep 4, 2024

No description provided.

@deepsource-io deepsource.io
Copy link
deepsource-io bot commented Sep 4, 2024 •
edited
Loading

Here's the code health analysis summary for commits 6af24d2..ff2c16b. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource Go LogoGo❌ Failure
❗ 9 occurences introduced
🎯 19 occurences resolved
View Check ↗

Code Coverage Report

MetricAggregateGo
Composite Coverage38.4%38.4%
Line Coverage38.4%38.4%
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@codecov Codecov
Copy link
codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
media/media_library/media_library.go 60.00% 1 Missing and 1 partial ⚠️
media/base/base.go 50.00% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
autocomplete/model.go 77.58% <ø> (-0.38%) ⬇️
media/filechooser.go 88.33% <100.00%> (-0.02%) ⬇️
media/base/base.go 54.22% <50.00%> (ø)
media/media_library/media_library.go 82.89% <60.00%> (-2.44%) ⬇️

@molon molon merged commit aa5d83b into main Sep 4, 2024
10 of 11 checks passed
@molon molon deleted the fix-deepsource branch September 10, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@molon @theplant-ci
0