8000 Support after title comp without drawer by ZLValien · Pull Request #561 · qor5/admin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support after title comp without drawer #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 10, 2024
Merged

Support after title comp without drawer #561

merged 15 commits into from
Sep 10, 2024

Conversation

ZLValien
Copy link
Contributor
@ZLValien ZLValien commented Sep 9, 2024

Support after title comp without drawer

@deepsource-io deepsource.io
Copy link
deepsource-io bot commented Sep 9, 2024 •
edited
Loading

Here's the code health analysis summary for commits 0f47188..4e41326. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource Go LogoGo✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateGo
Composite Coverage39%39%
Line Coverage39%39%
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@codecov Codecov
Copy link
codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.47368% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
presets/menu_order.go 87.78% 10 Missing and 6 partials ⚠️
Files with missing lines Coverage Δ
presets/menu_group.go 86.66% <100.00%> (+2.05%) ⬆️
presets/presets.go 72.88% <100.00%> (-0.73%) ⬇️
presets/menu_order.go 87.78% <87.78%> (ø)

... and 5 files with indirect coverage changes

ZLValien and others added 4 commits September 9, 2024 15:21
@ZLValien
Fix deepsource issues
11287da
@ZLValien
Fix deepsource issues
4d46d6a
@ZLValien
refactor menu order
e201004
@deepsource-autofix
style: format code with Gofumpt
7f28eb3 
This commit fixes the style issues introduced in e201004 according to the output
from Gofumpt.

Details: #561
@theplant-ci theplant-ci added size/L and removed size/M labels Sep 9, 2024
@theplant-ci theplant-ci added size/XL and removed size/L labels Sep 9, 2024
@ZLValien ZLValien merged commit 21eccf6 into main Sep 10, 2024
11 checks passed
@shenzhaoyan shenzhaoyan deleted the feat-after-title branch September 10, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molon molon molon approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZLValien @molon @theplant-ci
0