8000 Refactor create menu by ZLValien · Pull Request #580 · qor5/admin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor create menu #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 13, 2024
Merged

Refactor create menu #580

merged 4 commits into from
Sep 13, 2024

Conversation

ZLValien
Copy link
Contributor

Refactor create menu

ZLValien and others added 2 commits September 13, 2024 14:15
@ZLValien
Refactor create menu
b318923
@deepsource-autofix
style: format code with Gofumpt
d93c979 
This commit fixes the style issues introduced in b318923 according to the output
from Gofumpt.

Details: #580
@deepsource-io deepsource.io
Copy link
deepsource-io bot commented Sep 13, 2024 •
edited
Loading

Here's the code health analysis summary for commits fb729f2..dc84f0f. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource Go LogoGo✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateGo
Composite Coverage39.8%39.8%
Line Coverage39.8%39.8%
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@codecov Codecov
Copy link
codecov bot commented Sep 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.11111% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
presets/menu_order.go 91.11% 5 Missing and 3 partials ⚠️
Files with missing lines Coverage Δ
presets/menu_order.go 91.60% <91.11%> (+3.82%) ⬆️

... and 1 file with indirect coverage changes

@ZLValien ZLValien merged commit a1599a9 into main Sep 13, 2024
11 checks passed
@ZLValien ZLValien deleted the refactor-menu-order branch September 13, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunfmin sunfmin sunfmin approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZLValien @sunfmin @theplant-ci
0