8000 pagebuilder add PreviewOpenNewTab by zhangshanwen · Pull Request #584 · qor5/admin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

pagebuilder add PreviewOpenNewTab #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2024
Merged

pagebuilder add PreviewOpenNewTab #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a62249
pagebuilder add PreviewOpenNewTab
zhangshanwen Sep 14, 2024
af121f7
style: format code with Gofumpt
deepsource-autofix[bot] Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/docsrc/examples/examples_admin/page_builder_with_campaign.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ func PageBuilderExample(b *presets.Builder, db *gorm.DB) http.Handler {
pb := pagebuilder.New(b.GetURIPrefix()+"/page_builder", db).
Activity(ab).
DisabledNormalContainersGroup(true).
PreviewOpenNewTab(true).
Publisher(puBuilder).
PreviewDevices(
pagebuilder.Device{Name: pagebuilder.DeviceComputer, Width: "", Icon: "mdi-monitor", Disabled: true},
Expand Down
2 changes: 1 addition & 1 deletion docs/docsrc/examples/examples_admin/page_builder_with_campaign_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ func TestPageBuilderCampaign(t *testing.T) {
pageBuilderData.TruncatePut(dbr)
return httptest.NewRequest("GET", "/campaign-products/1_2024-05-20-v01", nil)
},
ExpectPageBodyContainsInOrder: []string{"publish_EventPublish", "ProductDetail"},
ExpectPageBodyContainsInOrder: []string{"publish_EventPublish", "_blank", "ProductDetail"},
},
{
Name: "Campaign My Contents",
Expand Down
1 change: 1 addition & 0 deletions example/integration/pagebuilder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ func TestPageBuilder(t *testing.T) {
ExpectPageBodyContainsInOrder: []string{
`Page`, `SEO`, `Activity`,
},
ExpectPageBodyNotContains: []string{"_blank"},
},
{
Name: "Page Builder Detail editor",
Expand Down
6 changes: 6 additions & 0 deletions pagebuilder/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ type Builder struct {
expendContainers bool
pageEnabled bool
disabledNormalContainersGroup bool
previewOpenNewTab bool
previewContainer bool
templateInstall presets.ModelInstallFunc
pageInstall presets.ModelInstallFunc
Expand Down Expand Up @@ -289,6 +290,11 @@ func (b *Builder) ExpendContainers(v bool) (r *Builder) {
return b
}

func (b *Builder) PreviewOpenNewTab(v bool) (r *Builder) {
b.previewOpenNewTab = v
return b
}

func (b *Builder) DisabledNormalContainersGroup(v bool) (r *Builder) {
b.disabledNormalContainersGroup = v
return b
Expand Down
6 changes: 5 additions & 1 deletion pagebuilder/settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ func overview(m *ModelBuilder) presets.FieldComponentFunc {
copyURL = fmt.Sprintf(`%q`, previewDevelopUrl)
}
}
previewComp := h.A(h.Text(previewDevelopUrl)).Href(previewDevelopUrl)
if m.builder.previewOpenNewTab {
previewComp.Target("_blank")
}
return h.Div(
onlineHint,
versionComponent,
Expand Down Expand Up @@ -112,7 +116,7 @@ transform-origin: 0 0; transform:scale(0.5);width:200%;height:200%`),
web.Plaid().URL(m.editorURLWithSlug(ps)).PushState(true).Go(),
),
h.Div(
h.A(h.Text(previewDevelopUrl)).Href(previewDevelopUrl),
previewComp,
VBtn("").Icon("mdi-content-copy").Color(ColorSecondary).Width(20).Height(20).Variant(VariantText).Size(SizeXSmall).Class("ml-1 fix-btn-icon").
Attr("@click", fmt.Sprintf(`$event.view.window.navigator.clipboard.writeText(%s);vars.presetsMessage = { show: true, message: "success", color: %q}`, copyURL, ColorSuccess)),
).Class("d-inline-flex align-center py-4"),
Expand Down
Loading
0