8000 page only fields by zhangshanwen · Pull Request #592 · qor5/admin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

page only fields #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 20, 2024
Merged

page only fields #592

merged 4 commits into from
Sep 20, 2024

Conversation

zhangshanwen
Copy link
Contributor

No description provided.

zhangshanwen and others added 2 commits September 20, 2024 11:14
@zhangshanwen
page only fields
040045d
@deepsource-autofix
style: format code with Gofumpt
715f5b9 
This commit fixes the style issues introduced in 040045d according to the output
from Gofumpt.

Details: #592
@zhangshanwen zhangshanwen requested a review from molon September 20, 2024 03:15
@deepsource-io deepsource.io
Copy link
deepsource-io bot commented Sep 20, 2024 •
edited
Loading

Here's the code health analysis summary for commits 89eb978..bcb06ef. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource Go LogoGo✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateGo
Composite Coverage40.2% (up 0.1% from main)40.2% (up 0.1% from main)
Line Coverage40.2% (up 0.1% from main)40.2% (up 0.1% from main)
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@codecov Codecov
Copy link
codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.04762% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pagebuilder/page.go 90.74% 2 Missing and 3 partials ⚠️
Files with missing lines Coverage Δ
pagebuilder/builder.go 79.00% <100.00%> (+0.28%) ⬆️
pagebuilder/settings.go 89.30% <100.00%> (+0.13%) ⬆️
utils/slice.go 100.00% <100.00%> (ø)
pagebuilder/page.go 91.81% <90.74%> (+0.47%) ⬆️

@zhangshanwen zhangshanwen merged commit 2a02f90 into main Sep 20, 2024
11 checks passed
@zhangshanwen zhangshanwen deleted the fix-page-field branch September 20, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molon molon molon approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangshanwen @molon @theplant-ci
0