8000 Fix seo by zhangshanwen · Pull Request #594 · qor5/admin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix seo #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 24, 2024
Merged

Fix seo #594

merged 7 commits into from
Sep 24, 2024

Conversation

zhangshanwen
Copy link
Contributor

No description provided.

zhangshanwen and others added 4 commits September 24, 2024 11:11
@zhangshanwen
fix seo ui;
7bb4516
@zhangshanwen
field defaults;
5aa0cfc
@zhangshanwen
add test
97a285d
@deepsource-autofix
style: format code with Gofumpt
21dd973 
This commit fixes the style issues introduced in 97a285d according to the output
from Gofumpt.

Details: #594
@zhangshanwen zhangshanwen requested a review from molon September 24, 2024 03:41
@deepsource-io deepsource.io
Copy link
deepsource-io bot commented Sep 24, 2024 •
edited
Loading

Here's the code health analysis summary for commits d2bde63..3bc83dd. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource Go LogoGo✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateGo
Composite Coverage40.3% (up 0.1% from main)40.3% (up 0.1% from main)
Line Coverage40.3% (up 0.1% from main)40.3% (up 0.1% from main)
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@codecov Codecov
Copy link
codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 69.81132% with 64 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
seo/admin.go 33.33% 46 Missing ⚠️
pagebuilder/helper.go 50.00% 4 Missing and 3 partials ⚠️
pagebuilder/settings.go 89.09% 3 Missing and 3 partials ⚠️
presets/field_defaults.go 82.35% 3 Missing ⚠️
pagebuilder/page.go 94.28% 1 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
pagebuilder/builder.go 79.07% <100.00%> (+0.06%) ⬆️
pagebuilder/example/containers/heading.go 54.68% <100.00%> (+46.06%) ⬆️
pagebuilder/template_events.go 100.00% <100.00%> (ø)
presets/field.go 82.97% <100.00%> (+0.05%) ⬆️
presets/section.go 80.22% <ø> (+1.06%) ⬆️
pagebuilder/page.go 91.17% <94.28%> (-0.65%) ⬇️
presets/field_defaults.go 73.71% <82.35%> (-0.71%) ⬇️
pagebuilder/settings.go 87.66% <89.09%> (-1.65%) ⬇️
pagebuilder/helper.go 60.71% <50.00%> (ø)
seo/admin.go 46.42% <33.33%> (+3.10%) ⬆️

... and 2 files with indirect coverage changes

@sunfmin
Copy link
Contributor
sunfmin commented Sep 24, 2024

CfReadonlyCheckbox 这里的 Cf 应该是 ComponentFunc 的意思，可以去掉这种缩写直接用 ReadonlyCheckbox

zhangshanwen and others added 3 commits September 24, 2024 11:54
@zhangshanwen
rename func
a88bda7
@zhangshanwen
Merge branch 'fix-seo' of https://github.com/qor5/admin into fix-seo
72fd1e5
@deepsource-autofix
style: format code with Gofumpt
3bc83dd 
This commit fixes the style issues introduced in 72fd1e5 according to the output
from Gofumpt.

Details: #594
@zhangshanwen zhangshanwen merged commit 98718e3 into main Sep 24, 2024
11 checks passed
@zhangshanwen zhangshanwen deleted the fix-seo branch September 24, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molon molon molon approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhangshanwen @sunfmin @molon @theplant-ci
0