8000 pagebuilder: perm readonly for editor by molon · Pull Request #630 · qor5/admin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

pagebuilder: perm readonly for editor #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2024
Merged

pagebuilder: perm readonly for editor #630

merged 2 commits into from
Oct 10, 2024

Conversation

molon
Copy link
Contributor
@molon molon commented Oct 10, 2024

No description provided.

@molon molon requested a review from zhangshanwen October 10, 2024 07:15
@deepsource-io deepsource.io
Copy link
deepsource-io bot commented Oct 10, 2024 •
edited
Loading

Here's the code health analysis summary for commits 58056a8..4e5dd6e. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource Go LogoGo✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateGo
Composite Coverage40.7%40.7%
Line Coverage40.7%40.7%
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@codecov Codecov
Copy link
codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
example/admin/config.go 65.16% <100.00%> (+0.15%) ⬆️
example/admin/router.go 43.63% <100.00%> (+3.25%) ⬆️
pagebuilder/editor.go 89.22% <100.00%> (+1.07%) ⬆️
pagebuilder/model.go 70.88% <100.00%> (+0.18%) ⬆️

... and 9 files with indirect coverage changes

@molon molon merged commit 48f6ff7 into main Oct 10, 2024
11 checks passed
@molon molon deleted the pagebuilder-perm-readonly branch October 10, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangshanwen zhangshanwen zhangshanwen approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@molon @zhangshanwen @theplant-ci
0