8000 Add section validate only used in detailing by ZLValien · Pull Request #689 · qor5/admin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add section validate only used in detailing #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

Add section validate only used in detailing #689

merged 1 commit into from
Oct 29, 2024

Conversation

ZLValien
Copy link
Contributor

Not set every field when creating, but set them in detailing

@deepsource-io deepsource.io
Copy link
deepsource-io bot commented Oct 29, 2024 •
edited
Loading

Here's the code health analysis summary for commits 8c4ec03..0fed5b1. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource Go LogoGo✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateGo
Composite Coverage42.2% (up 0.1% from main)42.2% (up 0.1% from main)
Line Coverage42.2% (up 0.1% from main)42.2% (up 0.1% from main)
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@codecov Codecov
Copy link
codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.00000% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
presets/section.go 50.00% 7 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
example/admin/demo_case.go 93.81% <100.00%> (+0.04%) ⬆️
presets/section.go 77.51% <50.00%> (-0.52%) ⬇️

@ZLValien ZLValien requested a review from zhangshanwen October 29, 2024 07:13
@ZLValien ZLValien merged commit 99ed835 into main Oct 29, 2024
11 checks passed
@ZLValien ZLValien deleted the feat-section-validate branch October 29, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangshanwen zhangshanwen zhangshanwen approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZLValien @zhangshanwen @theplant-ci
0