8000 Feat validate by zhangshanwen · Pull Request #712 · qor5/admin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feat validate #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 5, 2024
Merged

Feat validate #712

merged 17 commits into from
Nov 5, 2024

Conversation

zhangshanwen
Copy link
Contributor

No description provided.

zhangshanwen and others added 15 commits October 31, 2024 10:38
@zhangshanwen
feat validate;restore delete row icon position
32c4110
@deepsource-autofix
style: format code with Gofumpt
2a2d129 
This commit fixes the style issues introduced in 32c4110 according to the output
from Gofumpt.

Details: #692
@zhangshanwen
errkey to errorKey
2fda655
@zhangshanwen
reopen page detail back button;validate add fetcher
d010a13
@deepsource-autofix
style: format code with Gofumpt
4fbec7b 
This commit fixes the style issues introduced in d010a13 according to the output
from Gofumpt.

Details: #692
@zhangshanwen
fix page slug to errorField ; Create Update Button use local isFetching
88418f0
@zhangshanwen
fix page detail slug CategoryID to VFieldError
a31cf54
@zhangshanwen
web.VField to presets.VFieldError
e1aa466
@zhangshanwen
fix Items Validate Failed Error Show;fix localizeMenu existLocals
2ccaf6b
@deepsource-autofix
style: format code with Gofumpt
7255568 
This commit fixes the style issues introduced in 2ccaf6b according to the output
from Gofumpt.

Details: #699
@zhangshanwen
demo case Name Can`t Empty
cf51970
@zhangshanwen
preset ModelBuilder add mustGetMessages func;fix Category delete just…
2aa137a 
… current locale code item
@deepsource-autofix
style: format code with Gofumpt
d6e4468 
This commit fixes the style issues introduced in 2aa137a according to the output
from Gofumpt.

Details: #704
@zhangshanwen
fix category delete with locale
20737f7
@zhangshanwen
Merge branch 'feat-validate' of https://github.com/qor5/admin into fe…
67f728a 
…at-validate
@deepsource-io deepsource.io
Copy link
deepsource-io bot commented Nov 5, 2024 •
edited
Loading

Here's the code health analysis summary for commits c8147c9..ce8c158. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource Go LogoGo✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateGo
Composite Coverage42.3% (up 0.2% from main)42.3% (up 0.2% from main)
Line Coverage42.3% (up 0.2% from main)42.3% (up 0.2% from main)
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@codecov Codecov
Copy link
codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.18342% with 67 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
example/admin/demo_case.go 87.43% 19 Missing and 7 partials ⚠️
presets/section.go 80.43% 13 Missing and 5 partials ⚠️
presets/editing.go 91.30% 7 Missing and 3 partials ⚠️
pagebuilder/example/containers/tag.go 0.00% 3 Missing ⚠️
presets/model.go 81.25% 3 Missing ⚠️
pagebuilder/builder.go 94.44% 0 Missing and 2 partials ⚠️
pagebuilder/example/containers/in_numbers.go 77.77% 1 Missing and 1 partial ⚠️
presets/field.go 88.88% 1 Missing and 1 partial ⚠️
pagebuilder/page.go 93.33% 1 Missing ⚠️
Files with missing lines Coverage Δ
example/admin/config.go 91.45% <100.00%> (-0.02%) ⬇️
l10n/config.go 47.87% <100.00%> (ø)
pagebuilder/example/containers/heading.go 51.47% <100.00%> (-0.71%) ⬇️
...agebuilder/example/containers/list_content_lite.go 51.66% <100.00%> (-0.80%) ⬇️
pagebuilder/helper.go 85.29% <ø> (-0.22%) ⬇️
pagebuilder/messages.go 33.33% <ø> (ø)
pagebuilder/settings.go 86.98% <100.00%> (+0.47%) ⬆️
presets/detailing.go 67.84% <100.00%> (+0.20%) ⬆️
presets/field_defaults.go 88.18% <100.00%> (+0.46%) ⬆️
presets/listeditor.go 68.30% <100.00%> (ø)
... and 13 more

... and 3 files with indirect coverage changes

@zhangshanwen zhangshanwen requested a review from molon November 5, 2024 07:04
@zhangshanwen zhangshanwen merged commit e17dabb into main Nov 5, 2024
11 checks passed
@zhangshanwen zhangshanwen deleted the feat-validate branch November 5, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molon molon molon approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangshanwen @molon @theplant-ci
0