Fix remove ps #963
Merged
Fix remove ps #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…do cancelChangeEvent
…k;fix highlight shadow size
- Modified multiple test cases across various files to replace `nil` with `http.NoBody` in `httptest.NewRequest` calls for improved clarity and consistency in handling empty request bodies. - This change enhances the readability of the test code and aligns with best practices for HTTP request handling.
- Updated the test cases in `fields_test.go` to replace string length checks with direct string comparisons for improved readability. - Modified the HTTP request creation in tests to use `http.NoBody` instead of `nil`, aligning with best practices for handling empty request bodies.
- Updated the test in `fields_test.go` to replace string length checks with direct string comparisons for enhanced clarity in error reporting. - This change aligns with previous refactoring efforts to simplify test assertions and improve code readability.
- Eliminated redundant return statements in multiple test cases within `demo_case_test.go`. - This change enhances code clarity and maintains consistency with previous refactoring efforts to simplify test assertions.
molon
approved these changes
May 12, 2025
…n support - Added a new function to dynamically set the editing title in the page builder based on the model ID and locale. - Updated the rename container dialog to include a script for setting the right content title. - Changed confirmation message keys in the publish messages to improve clarity and consistency across different languages. - Updated external asset links in the page layout for better versioning control.
- Added localization support for "no records to show" message in the related online pages tab of the page builder. - Introduced a new boolean flag to determine if online pages are present, improving the conditional rendering logic for the tab's content. - This change enhances user experience by providing clearer feedback when no related online pages are available.
refactor: enhance related online pages tab configuration
This reverts commit b1a5a6a.
- Modified the container wrapper in the editor to include an additional class "inner-container" for improved styling. - Added CSS to disable pointer events for the "inner-container" class, enhancing user interaction control in the editor.
- Introduced a new boolean flag `disabledShared` in the Builder struct to control the visibility of the "Mark as Shared" option in the UI. - Updated the rendering logic in `model_events.go` to conditionally display the sharing option based on the new flag, enhancing user experience by providing clearer control over container sharing.
- Removed the unnecessary class "inner-container" from the container wrapper when in readonly mode. - Changed the label "Add Row" to "Add Item" in English and Japanese message files for better clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.