8000 activity/publish: internal handling of i18n && detailing: fix title i18n by molon · Pull Request #372 · qor5/admin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

activity/publish: internal handling of i18n && detailing: fix title i18n #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 30, 2024
Merged

activity/publish: internal handling of i18n && detailing: fix title i18n #372

merged 12 commits into from
Jul 30, 2024

Conversation

molon
Copy link
Contributor
@molon molon commented Jul 30, 2024
  • presets: add LabelName method for model builder
  • listing: WrapDisplayColumns => WrapColumns
  • listing/detailing: add Title method
  • activity: internal handling of i18n
    • listing table header
    • listing title / detailing title / menu name
    • listing / detailing / timeline ...
      • action label via ModelsI18nModuleKey (ActivityActionLogin / ActivityActionXXX)
      • model name via ModelsI18nModuleKey

@theplant-ci
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov Codecov
Copy link
codecov bot commented Jul 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.77876% with 57 lines in your changes missing coverage. Please review.

Files Coverage Δ
activity/messages.go 33.33% <ø> (ø)
activity/model_builder.go 75.51% <100.00%> (+0.51%) ⬆️
activity/timeline.go 65.41% <100.00%> (ø)
activity/util.go 64.10% <100.00%> (+1.94%) ⬆️
docs/docsrc/examples/examples_admin/activity.go 92.85% <100.00%> (+0.26%) ⬆️
docs/docsrc/examples/examples_presets/listing.go 27.44% <100.00%> (+0.33%) ⬆️
presets/context.go 81.81% <ø> (ø)
presets/model.go 85.71% <100.00%> (+0.99%) ⬆️
presets/nested_many.go 67.85% <100.00%> (+0.78%) ⬆️
publish/builder.go 81.57% <100.00%> (+0.45%) ⬆️
... and 10 more

... and 16 files with indirect coverage changes

@molon
Copy link
Contributor Author
molon commented Jul 30, 2024

/test all

@theplant-ci
Copy link

@molon: No jobs can be run with /test all.
The following commands are available to trigger required jobs:

  • /test pull-qor5-plantbuild-verify

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@molon molon requested a review from zhangshanwen July 30, 2024 08:13
@molon molon marked this pull request as ready for review July 30, 2024 08:13
@molon molon requested a review from sunfmin July 30, 2024 09:24
@molon molon merged commit 3fc4738 into main Jul 30, 2024
4 checks passed
@molon molon deleted the i18nx branch August 7, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunfmin sunfmin sunfmin approved these changes

@zhangshanwen zhangshanwen Awaiting requested review from zhangshanwen

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@molon @theplant-ci @sunfmin
0