8000 Fix using exposed `check-dir` when uploading artifacts by riccardoporreca · Pull Request #560 · r-lib/actions · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix using exposed check-dir when uploading artifacts #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2022
Merged

Fix using exposed check-dir when uploading artifacts #560

merged 1 commit into from
May 17, 2022

Conversation

riccardoporreca
Copy link
Contributor

A hard-coded check was still used when uploading artifacts.

Given the R-expression-nature of inputs.check-dir, I relied on the resolved path included by rcmdcheck::rcmdcheck in the returned object (not sure if there is a better alternative to this).

Tested in a workflow with

      - uses: r-lib/actions/check-r-package@v2-branch
        with:
          check-dir: '"non-default-dir"'
          upload-results: true
          upload-snapshots: true

https://github.com/riccardoporreca/actions/runs/6460856210?check_suite_focus=true#step:6:149

Warning: No files were found with the provided path: ./check. No artifacts will be uploaded.

https://github.com/riccardoporreca/actions/runs/6460856210?check_suite_focus=true#step:6:163

No files were found with the provided path: ./check/**/tests*/testthat/_snaps. No artifacts will be uploaded.

Artifacts are correctly uploaded when using the branch with the proposed fix:
https://github.com/riccardoporreca/actions/actions/runs/2334950233#artifacts

@riccardoporreca
Fix using exposed check-dir when uploading artifacts
af9ea8e 
Given the R-expression-nature of `inputs.check-dir`, we rely on the resolved path included by `rcmdcheck::rcmdcheck` in the returned object.
@gaborcsardi
Copy link
Member

Thanks, looks good!

@gaborcsardi gaborcsardi merged commit 4f5b34c into r-lib:v2-branch May 17, 2022
@riccardoporreca riccardoporreca mentioned this pull request Aug 4, 2022
Closed
riccardoporreca added a commit to riccardoporreca/actions that referenced this pull request Aug 4, 2022
@riccardoporreca
Fix resolving the exposed check-dir for the artifact upload
2dbc0b3 
* Given the R-expression-nature of `inputs.check-dir`, we still rely on a step output defined from within R but just uses the expression.
* We need to define the output before running the checks to fix r-lib#593 (introduced by r-lib#560) in case of check failures.
@riccardoporreca riccardoporreca mentioned this pull request Aug 4, 2022
Merged
@riccardoporreca riccardoporreca mentioned this pull request Sep 5, 2022
Closed
@github-actions
Copy link
github-actions bot commented Nov 4, 2022

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riccardoporreca @gaborcsardi
0