8000 codecov/codecov-action v4->v5 by MichaelChirico · Pull Request #984 · r-lib/actions · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

codecov/codecov-action v4->v5 #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 19, 2025
Merged

codecov/codecov-action v4->v5 #984

merged 3 commits into from
Mar 19, 2025

Conversation

MichaelChirico
Copy link
Contributor

@remlapmot
Copy link
Contributor

I think this PR probably needs two additional amends, because two argument names appear to have been amended in v5:

https://github.com/codecov/codecov-action?tab=readme-ov-file#arguments

  • file to files
  • plugin to plugins

(Weirdly your runs on lintr are showing as passed when in fact the codecov-action step actually errors - I only noticed as this just happened in my own repos)

CleanShot 2025-02-24 at 08 48 12@2x

CleanShot 2025-02-24 at 08 48 54@2x

@MichaelChirico
Copy link
Contributor Author

Ah, thanks for vetting. I saw the different arguments mentioned in the changelog but naively assumed that the passed CI meant it had no effect in our case.

@MichaelChirico MichaelChirico mentioned this pull request Feb 24, 2025
Merged
@remlapmot
Copy link
Contributor

Just a reminder this can be merged.

Example yml using this: https://github.com/remlapmot/OneSampleMR/blob/main/.github/workflows/test-coverage.yaml

Example successful run: https://github.com/remlapmot/OneSampleMR/actions/runs/13493925815/job/37696918323

@gaborcsardi gaborcsardi merged commit c8e6990 into r-lib:v2-branch Mar 19, 2025
27 checks passed
@gaborcsardi
Copy link
Member

Thanks!

@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 3, 2025

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaborcsardi gaborcsardi gaborcsardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelChirico @remlapmot @gaborcsardi
0