Add response methods for read_xml and read_html #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also convert read_html to a generic Fixes r-lib#63
3f38b67 to
90fc759
Compare
Current coverage is 59.59%@@ master #93 diff @@
==========================================
Files 30 30
Lines 1345 1356 +11
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 798 808 +10
- Misses 547 548 +1
Partials 0 0
|
| @@ -20,3 +20,13 @@ quote_str <- function(x, quote = "\"") { | |||
|
|
|||
| paste0(quote, x, quote) | |||
| } | |||
|
|
|||
| is_installed <- function(pkg) { | |||
| system.file(package = pkg) != "" | |||
There was a problem hiding this comment.
Can we use requireNamespace(quietly = TRUE) instead?
There was a problem hiding this comment.
Sure (this is originally from https://github.com/hadley/httr/blob/master/R/utils.r#L35)
There was a problem hiding this comment.
You should never trust that guy's code!
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also convert read_html to a generic.
Perhaps the
need_package("xml")is unnecessary, as how do you get a response object without having httr installed, but I put it in there to be safe.