8000 xml_add_* methods now return invisibly. by sjp · Pull Request #124 · r-lib/xml2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

xml_add_* methods now return invisibly. #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2016
Merged

xml_add_* methods now return invisibly. #124

merged 1 commit into from
Dec 5, 2016

Conversation

sjp
Copy link
Contributor
@sjp sjp commented Sep 13, 2016

As above. Should close #117.

@jimhester jimhester merged commit 4621a0e into r-lib:master Dec 5, 2016
@jennybc
Copy link
Member
jennybc commented Dec 5, 2016

Apologies if I am off-base, but how could this close #117? I think this closes #107 instead.

@jimhester
Copy link
Member
jimhester commented Dec 6, 2016 •
edited
Loading

Yes correct this closes #107.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xml_attr <- auto convert other types to charaters
3 participants
@sjp @jennybc @jimhester
0