add ... to xml_structure and descendents, closes #244 #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 12, 2019 11:17
|
Thank you for working on the pull request! I ended up implementing this in a different way, exposing the I did use the test from this PR, so thank you for including that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#244
This is the simplest implementation but IMO not ideal:
A bit awkward about
sep. Maybe makesepan argument as well? Seems the simplest way to catch duplicatedsepat the outset. Otherwise will have to look atmatch.call? But I wasn't sure whether to only put a test forsepat the top (inxml_structureandhtml_structure?l@exported functions? Whenevercatshows up?)Seems a bit odd that you have to remember to supply
append = TRUE... seems reasonable to expect a call toxml_structureto make only one file. And the current API means if your desired behavior is to overwrite an existing file with the full output ofxml_structure(not a particularly odd behavior IMO), you're out of luck (or at least need to do some more manual stuff; I don't think a lazyeval trick withappend = file.exists(file)will help since I think it will only evaluate once, not at each call?)