-
Notifications
You must be signed in to change notification settings - Fork 12
Refactor path handling to use pathlib in generate_model_info.py #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AntonPetrov
wants to merge
17
commits into
develop
Choose a base branch
from
cosine/refactor/use-pathlib-u470z3
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix docker builds, sanitise fasta headers, traveler update
Merge pull request #178 from r2dt-bio/develop
…n generate_model_info.py Co-authored-by: Genie <genie@cosine.sh>
Docker image tag(s) pushed:
Labels added to images:
|
Co-authored-by: Genie <genie@cosine.sh>
… readability and maintainability Co-authored-by: Genie <genie@cosine.sh>
Co-authored-by: Genie <genie@cosine.sh>
…re.py Co-authored-by: Genie <genie@cosine.sh>
Co-authored-by: Genie <genie@cosine.sh>
0dddf74
to
b7e0824
Compare
Co-authored-by: Genie <genie@cosine.sh>
b7e0824
to
895ff53
Compare
Co-authored-by: Genie <genie@cosine.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
generate_model_info.py
file to replace the use of theos
module withpathlib
for path manipulations. The changes include:os.path.join
with the/
operator frompathlib
for constructing paths.Path.glob
for pattern matching instead ofglob.glob
.Path.open()
instead of the built-inopen()
function.These changes improve the readability and maintainability of the code by utilizing the more modern
pathlib
library for path operations.Original Task: R2DT/vyy62m895ohk
Author: Anton Petrov