8000 Standardize permission policy check logic · Issue #7206 · rucio/rucio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Standardize permission policy check logic #7206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rdimaio opened this issue Dec 4, 2024 · 4 comments · Fixed by #7388
Closed

Standardize permission policy check logic #7206

rdimaio opened this issue Dec 4, 2024 · 4 comments · Fixed by #7388
Assignees
@jamesp-epcc
Labels
Policies
Milestone
37.0.0

Comments

@rdimaio
Copy link
Contributor
rdimaio commented Dec 4, 2024 
          However, checking the code, it seems this is not uses consistently.

lib/rucio/core/permission/__init__.py has in fact complex logic to determine the policy, but in several places in the code, a simple config_get("policy", "permission") is done instead.

Originally posted by @maxnoe in rucio/documentation#391 (comment)

See also: rucio/documentation#391 (comment)
This was referenced Dec 4, 2024
Closed
Closed
jamesp-epcc added a commit to jamesp-epcc/rucio that referenced this issue Feb 6, 2025
@jamesp-epcc
Policies: standardise permission policy check logic rucio#7206
c5ae88f
jamesp-epcc added a commit to jamesp-epcc/rucio that referenced this issue Feb 6, 2025
@jamesp-epcc
Policies: standardise permission policy check logic rucio#7206
5929d01
jamesp-epcc added a commit to jamesp-epcc/rucio that referenced this issue Feb 7, 2025
@jamesp-epcc
Policies: standardise permission policy check logic rucio#7206
9145d13
@jamesp-epcc jamesp-epcc linked a pull request Feb 7, 2025 that will close this issue
Policies: standardise permission policy check logic #7206 #7388
Merged
jamesp-epcc added a commit to jamesp-epcc/rucio that referenced this issue Feb 10, 2025
@jamesp-epcc
Policies: standardise permission policy check logic rucio#7206
02ac315
@jamesp-epcc jamesp-epcc moved this from In Progress to In Review in Rucio 37 “Dungeons & Donkeys” release roadmap Feb 11, 2025
@rdimaio
Copy link
Contributor Author
rdimaio commented Feb 13, 2025

To also fix: in https://rucio.github.io/documentation/operator/configuration_parameters/#policy, policy.permission says :permission: Same as policy/permission - so it autoreferences itself

@maxnoe
Copy link
Contributor
maxnoe commented Feb 13, 2025 •
edited
Loading

Isn't this fixed? https://github.com/rucio/documentation/pull/391/files

@rdimaio
Copy link
Contributor Author
rdimaio commented Feb 13, 2025

Isn't this fixed? https://github.com/rucio/documentation/pull/391/files

Looks like it was accidentally added back here rucio/documentation@80a67a9

@rdimaio
Copy link
Contributor Author
rdimaio commented Feb 13, 2025

Quick PR to fix the doc issue rucio/documentation#473

bari12 pushed a commit that referenced this issue Feb 13, 2025
@jamesp-epcc @bari12
Policies: standardise permission policy check logic #7206
e383672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesp-epcc jamesp-epcc

Labels
Policies
Projects
No open projects
Rucio 37 “Dungeons & Donkeys” release roadmap
Status: Done
Milestone
37.0.0
Development

Successfully merging a pull request may close this issue.

Policies: standardise permission policy check logic #7206 jamesp-epcc/rucio
4 participants
@bari12 @maxnoe @jamesp-epcc @rdimaio
0