8000 `test-curl` tests fails in dev envoriments · Issue #7507 · rucio/rucio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test-curl tests fails in dev envoriments #7507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
voetberg opened this issue Mar 17, 2025 · 0 comments · Fixed by #7533
Closed

test-curl tests fails in dev envoriments #7507

voetberg opened this issue Mar 17, 2025 · 0 comments · Fixed by #7533
Assignees
@0xquark
Labels
bug Testing
Milestone
37.0.0

Comments

@voetberg
Copy link
Contributor
voetberg commented Mar 17, 2025 •
edited
Loading

Description

About half of the test_curl tests fail when running in a dev environment - because the dev environment does not have a x509 cert the way these tests expect.

FAILED tests/test_curl.py::TestCurlRucio::test_get_auth_x509 - AssertionError: assert 'X-Rucio-Auth-Token' in ''
FAILED tests/test_curl.py::TestCurlRucio::test_get_auth_validate - AssertionError: assert 'X-Rucio-Auth-Token' in ''
FAILED tests/test_curl.py::TestCurlRucio::test_post_account - AssertionError: assert 'X-Rucio-Auth-Token' in ''
FAILED tests/test_curl.py::TestCurlRucio::test_get_accounts_whoami - AssertionError: assert 'X-Rucio-Auth-Token' in ''
FAILED tests/test_curl.py::TestCurlRucio::test_post_rse - AssertionError: assert 'X-Rucio-Auth-Token' in ''

Steps to reproduce

  • install the dev environment using the instructions here
  • Run either bash tools/run_tests.sh or pytest tests/test_curl.py - observe the failed tests

Rucio Version

No response

Additional Information

I propose we mark these tests with a skip_if to only run them in the github runner or a specific environment.
@voetberg voetberg added the bug label Mar 17, 2025
@bari12 bari12 added the Testing label Mar 18, 2025
0xquark added a commit to 0xquark/rucio that referenced this issue Mar 20, 2025
@0xquark
tests: skip x509 auth cert tests outside github actions; fixes rucio#…
ac47c61 
…7507

- Marked x509-failed-tests with `pytest.mark.skipif` to skip tests
  outside CI (github actions) env for local runs.
- Github Actions has a env variable `GITHUB_ACTIONS` which is always set
  to true while running as part of the workflow.

Signed-off-by: Karanjot Singh <karanjot.singh@cern.ch>
@0xquark 0xquark mentioned this issue Mar 20, 2025
Merged
@0xquark 0xquark moved this from In Progress to In Review in Rucio 37 “Dungeons & Donkeys” release roadmap Mar 20, 2025
0xquark added a commit to 0xquark/rucio that referenced this issue Mar 20, 2025
@0xquark
tests: skip x509 auth cert tests outside github actions; fixes rucio#…
aaebfcd 
…7507

- Marked x509-failed-tests with `pytest.mark.skipif` to skip tests
  outside CI (github actions) env for local runs.
- Github Actions has a env variable `GITHUB_ACTIONS` which is always set
  to true while running as part of the workflow.

Signed-off-by: Karanjot Singh <karanjot.singh@cern.ch>
0xquark added a commit to 0xquark/rucio that referenced this issue Mar 20, 2025
@0xquark
tests: skip x509 auth cert tests outside github actions; fixes rucio#…
afe05af 
…7507

- Marked x509-failed-tests with `pytest.mark.skipif` to skip tests
  outside CI (github actions) env for local runs.
- Github Actions has a env variable `GITHUB_ACTIONS` which is always set
  to true while running as part of the workflow.

Signed-off-by: Karanjot Singh <karanjot.singh@cern.ch>
0xquark added a commit to 0xquark/rucio that referenced this issue Mar 20, 2025
@0xquark
tests: skip x509 auth cert tests outside github actions; fixes rucio#…
1ff71fe 
…7507

- Marked x509-failed-tests with `pytest.mark.skipif` to skip tests
  outside CI (github actions) env for local runs.
- Github Actions has a env variable `GITHUB_ACTIONS` which is always set
  to true while running as part of the workflow.

Signed-off-by: Karanjot Singh <karanjot.singh@cern.ch>
bari12 pushed a commit that referenced this issue Mar 21, 2025
@0xquark @bari12
tests: skip x509 auth cert tests outside github actions; fixes #7507
bd1fdfd 
- Marked x509-failed-tests with `pytest.mark.skipif` to skip tests
  outside CI (github actions) env for local runs.
- Github Actions has a env variable `GITHUB_ACTIONS` which is always set
  to true while running as part of the workflow.

Signed-off-by: Karanjot Singh <karanjot.singh@cern.ch>
@0xquark 0xquark mentioned this issue Mar 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xquark 0xquark

Labels
bug Testing
Projects
No open projects
Rucio 37 “Dungeons & Donkeys” release roadmap
Status: Done
Milestone
37.0.0
Development

Successfully merging a pull request may close this issue.

tests: skip x509 auth cert tests outside GitHub actions 0xquark/rucio
3 participants
@bari12 @voetberg @0xquark
0