8000 Addressed https://github.com/rubber/rubber/issues/177 issue. by egorelik · Pull Request #434 · rubber/rubber · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Addressed https://github.com/rubber/rubber/issues/177 issue. #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

egorelik
Copy link

This change addresses #177
and https://bugs.launchpad.net/ubuntu/+source/ec2-ami-tools/+bug/1088540 issues.

I pinned Ubuntu 13.04 repo only for ec2-ami-tools package to install latest package version.
Also added --no-filter switch for ec2-bundle-vol command to disable filtering for ssl keys and other files.

…s package. Added --no-filter flag to ec2-bundle-vol command
@nirvdrum
Copy link
Member

I'll give this a review shortly. In the future though, please try to keep whitespace changes separate. I agree we shouldn't have all this empty whitespace, but it makes merging harder and muddles the diff with all the changes in there.

@nirvdrum
Copy link
Member

Is there a more recent repo we can use? I'm worried about the 13.04 one being obsoleted in 3 months when 13.04 reaches its end-of-life.

@egorelik
Copy link
Author

We can use Ubuntu 13.10 which expires in July or point 13.04 apt list for this package to
http://old-releases.ubuntu.com/releases/ which should never expire

@nirvdrum
Copy link
Member

13.10 was a 9 month release, so it'll expire not much longer after. But I guess there's not a whole lot than can be done about that. Let's go with the 13.10 one for now. I'd like to get something more solid in place when 14.04 rolls out. A lot of the rubber templates will have to be overhauled due to package upgrades at that time anyway.

@egorelik
Copy link
Author

It says July, '14: https://wiki.ubuntu.com/Releases

How about changing installation to zip file: http://s3.amazonaws.com/ec2-downloads/ec2-ami-tools.zip ?

@nirvdrum
Copy link
Member

I have no experience with the zip installation, but I like the idea. It seems like it'd always be up-to-date and avoid the issue with expiring Ubuntu releases.

@egorelik
Copy link
Author

I'll change it to zip installation then

@nirvdrum
Copy link
Member

Awesome. Please let me know if you need any help with anything.

@nirvdrum
Copy link
Member
nirvdrum commented Apr 7, 2014

@egorelik Do you have any update on this? Thanks.

@egorelik
Copy link
Author
egorelik commented Apr 7, 2014

I'll push update this week

@egorelik
Copy link
Author
egorelik commented Jun 9, 2014

@nirvdrum any chance you could look into this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0