10000 Add OS matrix to Rust build and upgrade bindgen by vinistock · Pull Request #3594 · ruby/prism · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add OS matrix to Rust build and upgrade bindgen #3594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add OS matrix to Rust build and upgrade bindgen #3594

wants to merge 5 commits into from
+160 −325

Conversation

vinistock
Copy link
Collaborator
@vinistock vinistock commented Jul 3, 2025 •
edited
Loading

Compiling the Rust crate fails on Windows while generating bindings at the moment. I want to try to upgrade bindgen to the latest version to see if the issue has been fixed.

Also, this PR adds an OS matrix to the Rust builds, so that we can catch build issues sooner. This PR is easier to review by commit.

Notes:

  • As listed in the docs the wasm32-wasi target has been renamed to wasm32-wasip1
  • There were many new clippy violations. I fixed them in a separate commit, following clippy's instructions. None of them required any modifications outside of the recommendations
  • Compiling gems on Ruby head currently fails on Windows, so I changed the Rust bindings workflows to use 3.4
  • The WASM example doesn't support Windows and so I skipped running it on that OS

@vinistock vinistock marked this pull request as draft July 3, 2025 14:38
@vinistock vinistock force-pushed the vs_fix_windows_build branch 7 times, most recently from a4babe5 to fe820bb Compare July 3, 2025 16:57
@vinistock vinistock force-pushed the vs_fix_windows_build branch from fe820bb to ab22c39 Compare July 3, 2025 17:11
@vinistock vinistock force-pushed the vs_fix_windows_build branch from cd8bb9c to 3251900 Compare July 4, 2025 14:54
@vinistock vinistock marked this pull request as ready for review July 4, 2025 14:59
@rafaelfranca rafaelfranca added the Need another review Need an extra review label Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelfranca rafaelfranca rafaelfranca approved these changes

Assignees
No one assigned
Labels
Need another review Need an extra review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinistock @rafaelfranca
0