Eliminate deadcode from the Python codebase #976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
It might be worth it to add |
|
I added an issue here about deadcode: #989 |
palinatolmach
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #977.
I used the Python utility deadcode https://pypi.org/project/deadcode/ to detect unused code in this codebase. Still all of the methods in
__main__.pywhich are of the formdef exec_...are marked as dead by this tool because it does not understand the dynamic dispatch approach we used indef main():.I suspect that porting the updated sourcemaps approach from Simbolik to this tool resulted in also porting a lot of functions which are not used in Kontrol.
I came across this refactoring as I was trying to understand how to avoid rekompiling every time
kontrol buildis called.