Make enums rust enums not strings #1867
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea why the build/S3 test is failing? |
|
@luben I have rebased it on to master and fixed the tests, there was some places that needed string litterals replacing with the equivielant enum. |
|
What can be done to move this forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix to #340
This converts botocore shapes that are an enum into a rust enum.
Each enum has an
UknownVariantvariant that is used if the string that it is deserialised from is not a known variant.This means that it can implment both From and Into and always round trip back to the same string.
This means that unsupported future varaints can be sent via a simple
"FOO".into()and matched withThis require carefull attention as it would be a massive API change.
Edit 2021-02-25:
There are some ugly side effects of this. I had to add a default implementation to the enums so that input structs can derive default, I went with
UknownVariant("")as that is what the original code would have done but I don't like it.I also had to add a bunch of conversion impls for the enums which adds to the generated code size:
DisplayInto<Sting>,From<String>Into<&str>,From<&str>for a borrowed enumToParamSerializeandDeserializeif needed/configured