Display possible vspipe errors when ffmpeg pipe is present #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wait. Clippy is mad. |
|
Ah, I was getting an insane amount of borrow checker errors when implementing this, so I switched to manually doing |
|
Ping on Discord if you need help 👍 |
|
Should be fixed now, the real fix was to use |
|
Particularly since we have pedantic and nursery lints enabled, which tend to be buggier and have more false positives... which is another discussion. 🙂 |
mergify bot
pushed a commit
that referenced
this pull request
Jan 7, 2022
* Display possible errors vspipe when ffmpeg pipe is present * Fix clippy warnings (cherry picked from commit 38c1db6)
mergify bot
pushed a commit
that referenced
this pull request
Jan 7, 2022
* Display possible errors vspipe when ffmpeg pipe is present * Fix clippy warnings (cherry picked from commit 38c1db6)
redzic
added a commit
that referenced
this pull request
Jan 17, 2022
* Fixed a typo [enocoder => encoder] (#517) * new av1an preview * Update preview screenshot, again * Display possible vspipe errors when ffmpeg pipe is present (#519) * Display possible errors vspipe when ffmpeg pipe is present * Fix clippy warnings * Fixed mkvmerge on windows by allowing for commands over 32767 characters to be executed. (#521) * Fixed mkvmerge on windows by allowing for commands over 32767 characters to be executed. * Fix formatting * Fix errors * Fix clippy warnings Co-authored-by: Kesava Viswanadha <kviswanadha@berkeley.edu> Co-authored-by: Redzic <yusufredzic@gmail.com> * Fix mkvmerge concat (#523) * Call fix_path for mkvmerge concat (#533) * Call fix_path for mkvmerge concat * Fix formatting * Encoder mode/rate check (#532) * Encoder mode/rate check * Tweak Co-authored-by: Redzic <yusufredzic@gmail.com> * Re-add concat info to --help (#537) * Update version to 0.3.1 (#541) Co-authored-by: nusu-github <29514220+nusu-github@users.noreply.github.com> Co-authored-by: Zen <46526140+master-of-zen@users.noreply.github.com> Co-authored-by: redzic <48274562+redzic@users.noreply.github.com> Co-authored-by: KesavaViswanadha <79319318+KesavaViswanadha@users.noreply.github.com> Co-authored-by: Kesava Viswanadha <kviswanadha@berkeley.edu> Co-authored-by: Redzic <yusufredzic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes better error messages in the case of an ffmpeg pipe, where it would otherwise only display
pipe:: invalid data found when processing inputand the error from the encoder.Here is an error message with this PR, showing the error from all 3 places: