8000 Remove empty code block by romanz · Pull Request #452 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove empty code block #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2020
Merged

Remove empty code block #452

merged 1 commit into from
Aug 7, 2020

Conversation

romanz
Copy link
Contributor
@romanz romanz commented Aug 6, 2020 •
edited
Loading

Otherwise, cargo doc fails with:

warning: Rust code block is empty
   --> src/util/merkleblock.rs:442:9
    |
442 |     /// ```
    |         ^^^
    |
help: mark blocks that do not contain Rust code as text
    |
442 |     /// ```text
    |         ^^^^^^^

warning: 1 warning emitted

Kixunil
Kixunil previously approved these changes Aug 6, 2020
View reviewed changes
sgeisler
sgeisler previously approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor
@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also remove the superfluous blank line?

@romanz romanz dismissed stale reviews from sgeisler and Kixunil via 406cfdf August 7, 2020 04:58
dpc
dpc approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor
@dpc dpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it. :)

elichai
elichai approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member
@elichai elichai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK
Makes sense, and I can reproduce the warning on master, and it's gone with this patch.

@elichai elichai mentioned this pull request Aug 7, 2020
Closed
@sgeisler sgeisler merged commit 0a25d87 into rust-bitcoin:master Aug 7, 2020
@romanz romanz deleted the rm-empty-block branch August 7, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpc dpc dpc approved these changes

@sgeisler sgeisler sgeisler approved these changes

@elichai elichai elichai approved these changes

@Kixunil Kixunil Kixunil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@romanz @dpc @Kixunil @sgeisler @elichai
0