8000 Add `Clone` instance to `RawNetworkMessage` by cloudhead · Pull Request #463 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Clone instance to RawNetworkMessage #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2020
Merged

Add Clone instance to RawNetworkMessage #463

merged 1 commit into from
Sep 1, 2020

Conversation

cloudhead
Copy link
Contributor

Very small change, but I've run into this too many times now. NetworkMessage has Clone, but not RawNetworkMessage. It's useful to have when there are multiple "consumers" of incoming network messages.

elichai
elichai approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member
@elichai elichai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheBlueMatt TheBlueMatt merged commit c8c187e into rust-bitcoin:master Sep 1, 2020
@cloudhead cloudhead deleted the cloudhead/clone-instance-raw-net-message branch September 1, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpc dpc dpc approved these changes

@sg 5EC3 eisler sgeisler sgeisler approved these changes

@elichai elichai elichai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cloudhead @dpc @sgeisler @elichai @TheBlueMatt
0