8000 Remove some dependencies; bump major version number by apoelstra · Pull Request #47 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove some dependencies; bump major version number #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 21, 2018
Merged

Remove some dependencies; bump major version number #47

merged 4 commits into from
Feb 21, 2018

Conversation

apoelstra
Copy link
Member

No description provided.

@apoelstra
Copy link
Member Author

cc @TheBlueMatt ; I didn't realize that using num like this was forcing all downstream users of the bignum types to also pull in num.

@apoelstra apoelstra changed the title Remove num crate dependency; bump major version number Remove some dependencies; bump major version number Feb 18, 2018
@apoelstra
Copy link
Member Author

Reduces the total build dependency list to 22 crates from 51. The remaining ones come from serde and strason, which in general need to be cleaned up. I may just feature-gate them at some point but it would be nice to also update serde and get rid of strason at the same time...but currently this is impossible, see serde-rs/serde#185

@apoelstra
Copy link
Member Author

Updated to add serde dependency to secp256k1, since (a) we already have this dependency at the top level (for now), and (b) I believe we need this for Liquid.

@TheBlueMatt
Copy link
Member

Tested, my stuff still compiles/passes tests, didn't review the backport of the jsonrpc/serde macros at all but looked over everything else.

@apoelstra
Copy link
Member Author

Great, thanks!

@apoelstra apoelstra merged commit 279e6de into master Feb 21, 2018
Tibo-lg pushed a commit to p2pderivatives/rust-bitcoin that referenced this pull request Sep 1, 2020
@stevenroose
Merge pull request rust-bitcoin#47 from johnyukon21/master
d4a3877 
Adding a README file at the top level with description and basic usage example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apoelstra @TheBlueMatt
0