[Trivial] add get_best_tip_height to blokchain #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22495c9 to
50a9d0f
Compare
|
I figured tip height it is accessible through get_block(best_tip().bitcoin_hash()).unwrap().height but that's ugly |
apoelstra
approved these changes
Mar 9, 2018
|
I also support blockchain out into its own crate. May I go ahaead, as I already worked on otimizing its performance? |
|
@tamasblummer Yes, I'd love that |
|
I'd say go for it!
…On March 9, 2018 3:05:09 PM UTC, "Tamás Blummer" ***@***.***> wrote:
I also support blockchain out into its own crate. May I go ahaead, as I
already worked on otimizing its performance?
--
You are receiving this because you are subscribed to this threa
8000
d.
Reply to this email directly or view it on GitHub:
#50 (comment)
|
|
Working on it. @apoelstra @TheBlueMatt : I think the script interpreter code should also be retired in favor of libbitcoinconsenus. |
|
Yea the rust implementation is out of date anyway, should almost certainly go (especially since it's a mutually-exclusive-with-Script build option that is non-default)
…On March 9, 2018 3:32:25 PM UTC, "Tamás Blummer" ***@***.***> wrote:
Working on it. @apoelstra @TheBlueMatt : I think the script interpreter
code should also be retired in favor of libbitcoinconsenus.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#50 (comment)
|
|
Agreed, I'd welcome a PR to remove the script_consensus stuff (or I will make one myself when I get a moment) |
yancyribbens
pushed a commit
to yancyribbens/rust-bitcoin
that referenced
this pull request
Mar 23, 2024
Added input sanitation to policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tip height is a useful information readily computed by the tree. It is e.g. needed to set the height in a version message that a peer would send. Added a public method to retrieve it.