Refactor use map_err #794
Merged
Refactor use map_err #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-orlovsky
reviewed
Jan 17, 2022
Kixunil
reviewed
Jan 17, 2022
src/util/psbt/serialize.rs
Outdated
| Ok(sig) => Ok(sig), | ||
| 8000 Err(schnorr::SchnorrSigError::InvalidSighashType(flag)) => { | ||
| Err(encode::Error::from(psbt::Error::NonStandardSigHashType(flag as u32))) | ||
| schnorr::SchnorrSig::from_slice(&bytes).map_err(|e| match e { |
There was a problem hiding this comment.
I feel that one of these styles would be easier to understand by readers:
schnorr::SchnorrSig::from_slice(&bytes)
.map_err(|e| match e {
...
})schnorr::SchnorrSig::from_slice(&bytes)
.map_err(|e|
match e {
...
}
)schnorr::SchnorrSig::from_slice(&bytes)
.map_err(|e|
match e {
...
}
)There was a problem hiding this comment.
thank you for review.
fixed code!
ee4e405 to
9f84847
Compare
|
i have refactor another place too |
|
I approved run but unless I'm too confused something it'll fail on missing commas. |
|
What the hell?! Commas are not mandatory? OMG I thought I knew Rust well. 🤣 |
Kixunil
approved these changes
Jan 18, 2022
According to the reference, comma after a BlockExpression(like https://doc.rust-lang.org/reference/expressions/match-expr.html |
apoelstra
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #793
change to using map_err