Add a disabled rustfmt.toml #803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not currently use `rustfmt`, this is a nuisance for devs who routinely work on code bases that do use rustfmt who often have their editors set to format on save. We can make the life of such devs much better by explicitly disabling formatting using `rustfmt.toml`. ref: https://rust-lang.github.io/rustfmt/?version=v1.4.38&search=#disable_all_formatting
thomaseizinger
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
tACK 08428ba
Ran cargo fmt locally and it did not do anything.
Perhaps it makes sense to also add a CI check right away? |
Kixunil
approved these changes
Jan 20, 2022
|
@thomaseizinger the value of CI for this is IMO close to zero. It's for contributors only and I don't expect it to change anytime soon. |
apoelstra
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not currently use
rustfmt, this is a nuisance for devs who routinely work on code bases that do use rustfmt who often have their editors set to format on save. We can make the life of such devs much better by explicitly disabling formatting usingrustfmt.toml.ref: https://rust-lang.github.io/rustfmt/?version=v1.4.38&search=#disable_all_formatting