Refactor logical operators #808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for refactoring `read_scriptbool` add passing unit tests.
Refactor and simplify the logical operators in `read_scriptbool`. Refactor only, no logic changes.
Refactor with the aim of simplifying `is_p2kh`. This function is covered sufficiently by current unit tests. Refactor only, no logic changes.
In an effort to make code containing multi-line logical AND clearer to read put the operator at the start of the line.
Refactor with the aim of making the code easier to read. Code path is covered by current unit tests. Refactor only, no logic changes.
Kixunil
previously approved these changes
Jan 25, 2022
Simplify `read_scriptbool` by doing: - Use `split_last` to get at the last element - Mask the last byte against ^0x80 instead of using two equality statements
Kixunil
approved these changes
Jan 26, 2022
apoelstra
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to make the code clearer and more explicit, do various refactorings around logical operators. Each done as a separate patch to ease review and limit scope of discussion.
Based on review of #806